Warning fixes (everywhere) #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... or the actions could just... not run. Warnings must be bad then. |
Daft-Freak
force-pushed
the
mostly-pico-warnings
branch
3 times, most recently
from
b4e51ed
to
d12e85e
Compare
|
5x the commits later... macOS and MinGW are clean, STM32 has 6 warnings, PicoSystem is mostly fixed by #764, VS is... VS and I'm leaving the clang-tidy stuff in the Linux build for now. (I ran |
Hmm, it's not that bad, Daft-Freak@d7bd600 fixes more than half of those (I was bored) |
Daft-Freak
force-pushed
the
mostly-pico-warnings
branch
from
e8936f2
to
64e7b4b
Compare
|
I guess I should merge this first and then duck under the maelstrom of merge conflicts 👀 |
|
Mmm yeah, I really got carried away there didn't I? 😆 |
This could only be a problem if reading >2GB was possible
Okay, actions won't see these but...
One of these has a missng break... but looking closer, none of them are actually used
This is causing warnings now, and doesn't appear to help any more either
This now has the opposite effect (more warnings), fun. This reverts commit a92b87d.
None of these have custom destructors or assignment operators, so we can just use the implicitly defined copies. This also avoids some -Wdeprecated-copy warnings
It's a 3rd-party lib and this also stops clang-tidy checking it
My local clang-tidy excludes minimp3 without this, the one in the action doesn't...
Remove unused variables and outdated commented out code
This still has the problem that all the code using ParticleGenerator is dead
Also save some memory in platformer by using the right size for the mask
Daft-Freak
force-pushed
the
mostly-pico-warnings
branch
from
64e7b4b
to
85275f4
Compare
|
QUICK! MERGE 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the mistake of looking at my build output.
After reducing the warning count a lot, this also sets the same warning flags as the boilerplate to hopefully catch more warnings. (May result in more commits if actions reports loads)